[Bug] LocalFlags().Visit / .NFlag failed, cannot count local flags have been set

[Roytangrb]

Describe the bug
I wanted to count the number of local flags that have been set explicitly, ignoring persisted global flags.

Yet the API LocalFlags().Visit, LocalFlags().NFlag, LocalNonPersistentFlags().Visit and LocalNonPersistentFlags().NFlag do not work

To Reproduce
While it seems intuitive to use the following API:

Run: func(cmd *cobra.Command, args []string) {
	flagCount := cmd.LocalFlags().NFlag() // always return 0
}

cmd.LocalNonPersistentFlags().NFlag() relies on LocalFlags(), it's having the same behaviour, always return 0

I also tried:

flagCount := 0
cmd.LocalFlags().Visit(func(f *pflag.Flag) {
	flagCount++
}
// flagCount outputs 0

The only workaround I came up with is:

flagCount := 0
cmd.LocalFlags().VisitAll(func(f *pflag.Flag) {
	if f.Changed {
		flagCount++
	}
})
// correct count of flags set

Expected behavior
LocalFlags().Visit() should visit the actual FlagSet whose value has been set explicitly
LocalFlags().NFlag() should return the count of local flags that have been se explicitly

Example output

cmd.LocalNonPersistentFlags().NFlag() 0
cmd.LocalFlags().NFlag() 0
// flag.Name(), flag.Change
body , changed:  false
breaking , changed:  false
description , changed:  true
footers , changed:  false
help , changed:  false
scope , changed:  true
type , changed:  true
FlagCount:  3

Additional context
I am not sure *pflag.FlagSet.actual field is supposed to present while LocalFlags() and LocalNonPersistentFlags are computed. It will be better if the NFlag and Visit API be consistent.

[github-actions]

This issue is being marked as stale due to a long period of inactivity

[Virtual-felix]

Any news ? I'm having the same issue, NFlag on local flags always return 0

[johnSchnake]

I agree that something wonky is happening here. Needs to be resolved.

[theclapp]

This is still a problem. As near as I can tell, cobra.Command.LocalFlags() tries to add all Flags() and PersistentFlags() to the local FlagSet, lflags. To do this it calls lflags.AddFlag(). But AddFlag doesn't touch lflags.actual (or any other *Actual fields), which is what Visit looks at. And indeed the only workaround I found was to use VisitAll and check flag.Changed.