Copy parsed flag values when constructing LocalFlags()
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR is being marked as stale due to a long period of inactivity |
|
Pinging this, CLA is signed |
johnSchnake
reviewed
Feb 21, 2022
| // If `f` has already been changed, re-add its value to the flag set, | ||
| // otherwise `c.lflags` has no record of the flags value. | ||
| if f.Changed { | ||
| f.Changed = false |
There was a problem hiding this comment.
Why is it that you need to unset the Changed field? I thought the point was to just copy over the new value, I didn't expect to see this modified as well.
|
I'm so sorry its taken so long to respond to this PR. We are actively trying to tackle the backlog. |
johnSchnake
added
area/flags-args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks in the failing test that #1019 references, and proposes a fix to
LocalFlags()not copying information about whether a flag has been parsed or not.If preferable, I can open a PR against spf13/pflag to change
flagSet.AddFlagto copy the fact that a flag already has a value instead of performing that logic here.