Add flags_completion as without @ format to _filedir #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so I see it doesn't work. you're right. I'm looking for the 'best' way to fix it.... |
eparis
added a commit
to eparis/cobra
that referenced
this pull request
May 4, 2015
We were trying to call a bash function with bash stuff like @ () from a variable. Stop that. Just call a function with an arg from a variable instead of trying to pass around the bash. Should fix spf13#103
|
what do you think of #105 ? |
eparis
added a commit
to eparis/cobra
that referenced
this pull request
May 4, 2015
We were trying to call a bash function with bash stuff like @ () from a variable. Stop that. Just call a function with an arg from a variable instead of trying to pass around the bash. Should fix spf13#103
muscliary
added a commit
to muscliary/cobra
that referenced
this pull request
Sep 12, 2023
We were trying to call a bash function with bash stuff like @ () from a variable. Stop that. Just call a function with an arg from a variable instead of trying to pass around the bash. Should fix spf13/cobra#103
desdeel2d0m
added a commit
to desdeel2d0m/cobra
that referenced
this pull request
Jul 1, 2024
We were trying to call a bash function with bash stuff like @ () from a variable. Stop that. Just call a function with an arg from a variable instead of trying to pass around the bash. Should fix spf13/cobra#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment, filename extentionsf for flags doesn't work.
It seems that the format
_filedir @(json|yaml|yml)doesn't work, but_filedir 'json|yaml|yml'works. I tested [1] with replacing as below.It may be my environment issue, but I hope if you could check it.
[1] https://github.com/GoogleCloudPlatform/kubernetes/blob/72f9e940a863878569571623669ef4a4add18cc2/contrib/completions/bash/kubectl#L54