Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): support no-space completions for short flags #1732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mazitovt
Copy link

Close #1629

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size/L Denotes a PR that chanes 100-199 lines label Jun 17, 2022
@mazitovt
Copy link
Author

@marckhouzam pls review the PR

@Luap99
Copy link
Contributor

Luap99 commented Jun 18, 2022

Duplicate of #1727?

@marckhouzam
Copy link
Collaborator

Thanks for the contribution @mazitovt !

Duplicate of #1727?

As @Luap99 noticed we just got a similar contribution in #1727. I've started reviewing that one and we should be getting it merged soon. I'll still have a look at yours as it may give a different perspective.

@mazitovt
Copy link
Author

@marckhouzam Thanks!

@marckhouzam
Copy link
Collaborator

@mazitovt I've had a look at this PR and it is a step in the right direction. It is very similar to #1727 which came in first, so I'll focus on #1727 for now.

One note for your info is that although the Go logic works with your PR, the actual shell completion does not work as expected because the different shell script need to be updated to support this usecase. Note that #1727 has the same problem, but we'll work at getting it resolved.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the PR is closed.
    You can:
  • Make a comment to remove the stale label and show your support. The 60 days reset. - If a PR has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interseted in reopening.

@marckhouzam
Copy link
Collaborator

Reopening. I plan on reviewing this. The other PR was closed by the author.

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the PR is closed.
    You can:
  • Make a comment to remove the stale label and show your support. The 60 days reset. - If a PR has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interested in reopening.

@github-actions github-actions bot closed this Jan 8, 2023
@marckhouzam marckhouzam reopened this Jan 8, 2023
@marckhouzam marckhouzam added area/shell-completion All shell completions lifecycle/frozen Prevents GitHub actions from labeling issues / PRs with stale and rotten and removed lifecycle/stale labels Jan 8, 2023
@marckhouzam marckhouzam added this to the 1.8.0 milestone Apr 5, 2023
@marckhouzam
Copy link
Collaborator

The CLA is not signed @mazitovt

@marckhouzam marckhouzam modified the milestones: 1.8.0, 1.9.0 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/shell-completion All shell completions lifecycle/frozen Prevents GitHub actions from labeling issues / PRs with stale and rotten size/L Denotes a PR that chanes 100-199 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell completion does not support the "no space" format of short flags
4 participants