New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(completion): support no-space completions for short flags #1732
base: main
Are you sure you want to change the base?
Conversation
|
@marckhouzam pls review the PR |
Duplicate of #1727? |
@marckhouzam Thanks! |
@mazitovt I've had a look at this PR and it is a step in the right direction. It is very similar to #1727 which came in first, so I'll focus on #1727 for now. One note for your info is that although the Go logic works with your PR, the actual shell completion does not work as expected because the different shell script need to be updated to support this usecase. Note that #1727 has the same problem, but we'll work at getting it resolved. |
The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:
|
Reopening. I plan on reviewing this. The other PR was closed by the author. |
The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:
|
The CLA is not signed @mazitovt |
Close #1629