Add Post terminator args support #1941
Conversation
- Add *Command.IgnorePostTerminatorArgs field for optin - Add method PostTerminatorArgs to get args after arg terminator "--" - Remove PostTerminatorArgs from args when IgnorePostTerminatorArgs=true
|
|
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
| @@ -33,78 +33,53 @@ func getCommand(args PositionalArgs, withValid bool) *Command { | |||
| } | |||
|
|
|||
| func expectSuccess(output string, err error, t *testing.T) { | |||
| t.Helper() | |||
There was a problem hiding this comment.
Adding t.Helper() avoid IDE to jump to that function when failing
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Is there any chance for that to be part of next release ? |
|
I would really like to use this. Any chance for getting it accepted and released? |
|
@adrian-gierakowski waiting for this since march 2023, the PR is now conflicting 😢 . I'm ok to make the extra work to get rid of conflict if this is not more that the user_guide.md to change, but the more maintainers wait to review this the more work risks to arise. Hope future will prove me wrong. |
This PR addresses #1895, adding an easy way to ignore args after the arg terminator --.
It also add easy retrieving of such arguments to easily manipulate them.
It is an optin feature, without setting IgnorePostTerminatorArgs to true it should not change anything, so no breaking change.
this PR includes:
Hope this can be of any help to others.