Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with proper install command as earlier cmd is deprecated. #2121

Closed
wants to merge 1 commit into from

Conversation

bhargavkeshav
Copy link

This is a small PR for the installation step update. Earlier go get command is deprecated and no longer supported - https://go.dev/doc/go-get-install-deprecation.

Please feel free to close this if its already being done as part of some other PR - cheers 👋

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024

CLA assistant check
All committers have signed the CLA.

@@ -83,7 +83,7 @@ Using Cobra is easy. First, use `go get` to install the latest version
of the library.

```
go get -u github.com/spf13/cobra@latest
go install github.com/spf13/cobra@latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go install is used to install executables: since spf13/cobra is a Go library for command line APIs, this is used to add the library to a go mod/sum:

In Go 1.18, go get will no longer build packages; it will only be used to add, update, or remove dependencies in go.mod

Closing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation🙂

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anytime!

@jpmcb jpmcb closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants