Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linkerd to list of projects using Cobra #892

Merged
merged 2 commits into from Jul 12, 2019

Conversation

scottcarol
Copy link

This PR adds Linkerd to the list of projects using Cobra.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2019

CLA assistant check
All committers have signed the CLA.

@scottcarol
Copy link
Author

is there a way to re-trigger the Travis CI build?

@umarcor
Copy link
Contributor

umarcor commented Jul 9, 2019

is there a way to re-trigger the Travis CI build?

Not directly, unless you are a maintainer of the repo.

However, you can trigger it indirectly by updating branch scottcarol:patch-1 in your fork. You can either push a 'dummy' commit (which should be squashed when merged), or you can update the existing commit (maybe --ammend it) and force push to your branch. Any of these will make Travis run the jobs again.

Nonetheless, note that the error is unrelated to your changes. The underlying problem is an issue in the current master branch that affects almost every PR. Hence, you won't get rid of the error until a fix (such as #889) is merged.

@jharshman
Copy link
Collaborator

@scottcarol rebase against master and the shellcheck errors should clear up.

@scottcarol
Copy link
Author

Thanks for the context @umarcor and @jharshman, will do.

bash: fix shellcheck errors (spf13#889)
@jharshman jharshman merged commit 9a31ddf into spf13:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants