Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to track cobra subdirectory #936

Closed

Conversation

rhcarvalho
Copy link

The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.

The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2019

CLA assistant check
All committers have signed the CLA.

@umarcor
Copy link
Contributor

umarcor commented Sep 5, 2019

Hi @rhcarvalho! I just sumitted a similar PR (#946). The difference is that you ignore an explicit location cobra/cobra, while I suggest to ignore any cobra which is not cobra/. wdyt?

@rhcarvalho
Copy link
Author

Hi @umarcor. I had considered initially a similar approach as what you wrote in your PR. However, on second thought and seeing how that line was introduced, I realized that ignoring /cobra/cobra is simpler and clearer, does what it needs to do and nothing more.

It is not possible to have a "cobra" executable in the top-level (because of the directory with the same name), and there is no good reason to generically ignore other files or directories named "cobra" in other paths.

@umarcor
Copy link
Contributor

umarcor commented Sep 5, 2019

Thanks for clarifying! I'm closing #946 in favour of this.

@jharshman jharshman mentioned this pull request Oct 7, 2019
@jharshman jharshman added this to the 1.0.0 milestone Oct 7, 2019
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 4, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 6, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
@umarcor umarcor mentioned this pull request Feb 3, 2020
@jharshman
Copy link
Collaborator

closed by #976

@jharshman jharshman closed this Feb 20, 2020
@umarcor
Copy link
Contributor

umarcor commented Feb 20, 2020

@jharshman, #976 seems to work around this issue, but not fix it. Using the makefiles will not produce cobra/cobra. However, users that build cobra explicitly will still find it, isn't it?

umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 4, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 11, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 13, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 25, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 1, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 14, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 18, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Dec 4, 2020
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 8, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 21, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 3, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 4, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 4, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Dec 10, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Dec 14, 2021
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 10, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 21, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 21, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 11, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 16, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 19, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 4, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 1, 2022
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 9, 2023
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 20, 2023
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 17, 2023
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 29, 2023
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 29, 2023
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.

Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants