Omit LICENSE file when license is set to none #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhcarvalho, would you mind rebasing thir PR, please? |
rhcarvalho
force-pushed
the
no-license
branch
from
b2c67a8
to
aaefa8e
Compare
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
Creating a project without a license should not create an empty LICENSE file.
rhcarvalho
force-pushed
the
no-license
branch
from
aaefa8e
to
3bba6a2
Compare
|
Rebased 🎉 |
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 22, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 22, 2020
Creating a project without a license should not create an empty LICENSE file.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 22, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 22, 2020
Creating a project without a license should not create an empty LICENSE file.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Feb 3, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Feb 3, 2020
Creating a project without a license should not create an empty LICENSE file.
Closed
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Feb 20, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Feb 20, 2020
Creating a project without a license should not create an empty LICENSE file.
jharshman
requested changes
Feb 26, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Mar 1, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Mar 1, 2020
Creating a project without a license should not create an empty LICENSE file.
|
Closing in favor of #1028 |
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Apr 13, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Apr 13, 2020
Creating a project without a license should not create an empty LICENSE file.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
May 11, 2020
Instead of writing to the current working directory, pick a random temp directory to test the CLI commands, keeping the working directory free of test side effects. In some cases the system default temp dir will also have some advantages like being mounted in an in-memory tmpfs.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
May 11, 2020
Creating a project without a license should not create an empty LICENSE file.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
May 11, 2020
Creating a project without a license should not create an empty LICENSE file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the documented purpose of
--license noneis to have no license, creating a project should not create an empty LICENSE file.