tpl: Fix deadlock in cached partials

Cached partials that contained cached partials would create a deadlock. Fixes #2935
gohugoio · Jan 18, 2017 · 3ac1b9f · 3ac1b9f
1 parent dc61d3b
commit 3ac1b9f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/tpl/template_funcs.go b/tpl/template_funcs.go
@@ -1541,7 +1541,10 @@ func (tf *templateFuncster) Get(key, name string, context interface{}) (p templa
 
 	tf.cachedPartials.Lock()
 	if p, ok = tf.cachedPartials.p[key]; !ok {
+		tf.cachedPartials.Unlock()
 		p = tf.t.partial(name, context)
+
+		tf.cachedPartials.Lock()
 		tf.cachedPartials.p[key] = p
 	}
 	tf.cachedPartials.Unlock()