tpl: Improve generation of OpenGraph date tags #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow all nodes/pages to use date-related OpenGraph meta tags, not only sites which are using the as-of-yet unfinished .Site.Authors functionality. Improve compliance of tags with Facebook's OpenGraph docs for the "website" and "article" types[0][1]. Also, use the proper tag for modification date (og:update_time vs article:modified_time). Generate date published using either .PublishDate or .Date, and use .Lastmod for modification date, which can use the new enableGitInfo functionality from Hugo 0.18, but seamlessly falls back to .Date if the site does not have this enabled/supported. [0] https://developers.facebook.com/docs/reference/opengraph/object-type/website/ [1] https://developers.facebook.com/docs/reference/opengraph/object-type/article/
bep
pushed a commit
that referenced
this pull request
Feb 21, 2017
A previous commit greatly improved the OpenGraph tags generated by Hugo's internal opengraph template, but there was a minor error in the fix. Nodes are of type "website" and according to the Facebook docs they should use og:updated_time. See: #2979 See: https://developers.facebook.com/docs/reference/opengraph/object-type/website/
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three major improvements. From the commit message:
.Site.Authorsfunctionality.og:update_timevsarticle:modified_time)..PublishDateor.Date, and use.Lastmodfor modification date, which can use the newenableGitInfofunctionality from Hugo 0.18, but seamlessly falls back to.Dateif the site does not have this enabled/supported.Tested on Facebook's OpenGraph debug tool and the new metadata is detected properly.
[0] https://developers.facebook.com/docs/reference/opengraph/object-type/website/
[1] https://developers.facebook.com/docs/reference/opengraph/object-type/article/