Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the alias generated HTML files to conform to the W3C HTML spec #1933

Closed
wants to merge 1 commit into from

Conversation

marvinpinto
Copy link
Contributor

  • W3C recommends that there be a whitespace character between the ; and the url= portions.
  • W3C also recommends that there be a title child in the head element

marvinpinto added a commit to marvinpinto/disjoint.ca that referenced this pull request Mar 8, 2016
…tion

The relevant upstream PR is: gohugoio/hugo#1933

This can/will undone once/if that lands upstream!
marvinpinto added a commit to marvinpinto/disjoint.ca that referenced this pull request Mar 8, 2016
…tion

The relevant upstream PR is: gohugoio/hugo#1933

This can/will undone once/if that lands upstream!
marvinpinto added a commit to marvinpinto/disjoint.ca that referenced this pull request Mar 8, 2016
…tion

The relevant upstream PR is: gohugoio/hugo#1933

This can/will undone once/if that lands upstream!
marvinpinto added a commit to marvinpinto/disjoint.ca that referenced this pull request Mar 8, 2016
…tion

Relevant upstream PR: gohugoio/hugo#1933

Will be easy to undo if/when that lands upstream!
@marvinpinto marvinpinto force-pushed the fix-meta-refresh branch 2 times, most recently from 509bc93 to 32c3513 Compare April 23, 2016 16:34
@marvinpinto
Copy link
Contributor Author

Hiya Hugo folks! Any chance I could get someone to have a look at this?

@SvenDowideit
Copy link
Contributor

@bep @spf13 is there a strong reason why this html is a constant in the golang, and not a reusable theme tmpl file?

@spf13
Copy link
Contributor

spf13 commented May 26, 2016

@SvenDowideit There's not a good reason. It was written before we had the theme support or embedded templates.

That said, I can't imagine needed to change it often and it's one of those things that if done right it should just work and doesn't need to be changed.

@marvinpinto this PR looks good.

@marvinpinto
Copy link
Contributor Author

Thank you for looking through the PR @spf13 :)

If nothing else is needed, would someone mind hitting the button?

@marvinpinto
Copy link
Contributor Author

marvinpinto commented May 29, 2016

I think that the build failures are related to either go-yaml/yaml or gokpg.in (the service), but I am not sure which.

Here are the relevant lines from the Travis build output:

Fetching https://gopkg.in/yaml.v2?go-get=1
Parsing meta tags from https://gopkg.in/yaml.v2?go-get=1 (status code 200)
get "gopkg.in/yaml.v2": found meta tag main.metaImport{Prefix:"gopkg.in/yaml.v2", VCS:"git", RepoRoot:"https://gopkg.in/yaml.v2"} at https://gopkg.in/yaml.v2?go-get=1
gopkg.in/yaml.v2 (download)
# cd .; git clone https://gopkg.in/yaml.v2 /home/travis/gopath/src/gopkg.in/yaml.v2
Cloning into '/home/travis/gopath/src/gopkg.in/yaml.v2'...
error: RPC failed; result=22, HTTP code = 502

Could I get some help with this?

(fyi - I rebased this branch off master which is what this triggered this rebuild)

- W3C recommends that there be a [whitespace character][1] between the
`;` and the `url=` portions.

- W3C also recommends that there be a [title][2] child in the `head`
element

[1]: https://www.w3.org/TR/html-markup/meta.http-equiv.refresh.html
[2]: https://www.w3.org/TR/html-markup/head.html
@marvinpinto
Copy link
Contributor Author

Build seems to be 💚 again, would someone mind merging if there's nothing else?

cc @bep @spf13

@bep
Copy link
Member

bep commented Jun 6, 2016

We will open for merges once Hugo 0.16 is released

@marvinpinto
Copy link
Contributor Author

Would someone be able to merge this now that 0.16 is out?

Ping @bep @anthonyfok @digitalcraftsman

@bep bep closed this Jun 9, 2016
@marvinpinto
Copy link
Contributor Author

Very much appreciate it, thank you @bep 😄

bep pushed a commit that referenced this pull request Jun 9, 2016
- W3C recommends that there be a [whitespace character][1] between the
`;` and the `url=` portions.

- W3C also recommends that there be a [title][2] child in the `head`
element

[1]: https://www.w3.org/TR/html-markup/meta.http-equiv.refresh.html
[2]: https://www.w3.org/TR/html-markup/head.html

Closes #1933
tychoish pushed a commit to tychoish/hugo that referenced this pull request Aug 13, 2017
- W3C recommends that there be a [whitespace character][1] between the
`;` and the `url=` portions.

- W3C also recommends that there be a [title][2] child in the `head`
element

[1]: https://www.w3.org/TR/html-markup/meta.http-equiv.refresh.html
[2]: https://www.w3.org/TR/html-markup/head.html

Closes gohugoio#1933
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants