New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the alias generated HTML files to conform to the W3C HTML spec #1933
Conversation
…tion The relevant upstream PR is: gohugoio/hugo#1933 This can/will undone once/if that lands upstream!
…tion The relevant upstream PR is: gohugoio/hugo#1933 This can/will undone once/if that lands upstream!
…tion The relevant upstream PR is: gohugoio/hugo#1933 This can/will undone once/if that lands upstream!
…tion Relevant upstream PR: gohugoio/hugo#1933 Will be easy to undo if/when that lands upstream!
c63defa
to
abc6a2f
Compare
49b4f8e
to
93e41a1
Compare
509bc93
to
32c3513
Compare
Hiya Hugo folks! Any chance I could get someone to have a look at this? |
@SvenDowideit There's not a good reason. It was written before we had the theme support or embedded templates. That said, I can't imagine needed to change it often and it's one of those things that if done right it should just work and doesn't need to be changed. @marvinpinto this PR looks good. |
Thank you for looking through the PR @spf13 :) If nothing else is needed, would someone mind hitting the button? |
32c3513
to
44c3a50
Compare
I think that the build failures are related to either go-yaml/yaml or gokpg.in (the service), but I am not sure which. Here are the relevant lines from the Travis build output:
Could I get some help with this? (fyi - I rebased this branch off master which is what this triggered this rebuild) |
44c3a50
to
d9108de
Compare
- W3C recommends that there be a [whitespace character][1] between the `;` and the `url=` portions. - W3C also recommends that there be a [title][2] child in the `head` element [1]: https://www.w3.org/TR/html-markup/meta.http-equiv.refresh.html [2]: https://www.w3.org/TR/html-markup/head.html
d9108de
to
cd576ad
Compare
We will open for merges once Hugo 0.16 is released |
Would someone be able to merge this now that 0.16 is out? |
Very much appreciate it, thank you @bep 😄 |
- W3C recommends that there be a [whitespace character][1] between the `;` and the `url=` portions. - W3C also recommends that there be a [title][2] child in the `head` element [1]: https://www.w3.org/TR/html-markup/meta.http-equiv.refresh.html [2]: https://www.w3.org/TR/html-markup/head.html Closes #1933
- W3C recommends that there be a [whitespace character][1] between the `;` and the `url=` portions. - W3C also recommends that there be a [title][2] child in the `head` element [1]: https://www.w3.org/TR/html-markup/meta.http-equiv.refresh.html [2]: https://www.w3.org/TR/html-markup/head.html Closes gohugoio#1933
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
;
and theurl=
portions.head
element