commands: Support human-readable YAML boolean values in undraft

[kropp]

Simplified version of #2831

[n10v]

Sorry for the stupid question, but how does it work, if it replaces nothing.

[kropp]

@BoGeM there is a loop over all frontmatter entries. Before this change, when draft key was found, it's value was changed from true to false. After this change this entry is skipped and not written to resulting frontmatter. Absent draft key means that the entry is not draft.

[n10v]

Thanks, now it's clear.
When the docs should be also edited, because initially undraft command sets undraft field from true to false. Now you just delete. It should be noticed.

[bep]

How is yes interpreted by go-yaml?

[kropp]

@BoGeM thanks, nice catch! I've updated my change.

[kropp]

@bep all values according to spec are supported: https://github.com/go-yaml/yaml/blob/v2/resolve.go#L37-L42

[bep]

@kropp that was not my question.

[kropp]

@bep yes is interpreted as true

[n10v]

Could you delete please the last line of help (If the content's draft status is 'False', nothing is done.). Your change removes the draft property despite the value.

[kropp]

@BoGeM No, undraft command does the check first and breaks if the given page is not draft (see https://github.com/kropp/hugo/blob/bf8aa82a5b638e88ba9529a26c7b81dfbda2e350/commands/undraft.go#L119-L122).

The documentation is therefore correct.

[n10v]

Ah ok, sorry for my inattention.
Then it looks good to me.
What do you think, @bep?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.