Add Parent FlagSet #357
Draft
Add Parent FlagSet #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
|
|
This was referenced Sep 5, 2022
AkihiroSuda
reviewed
Sep 5, 2022
| @@ -896,6 +896,19 @@ func (f *FlagSet) AddFlagSet(newSet *FlagSet) { | |||
| }) | |||
| } | |||
|
|
|||
| // AddParentFlagSet adds parent FlagSet to f. If a flag and shorthand is already present in f | |||
| // the flag from parentSet will be ignored. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent flags (
shorthand) of cmd's parents conflict with cmd's shorthand flags. We faced this issue multiple time within nerdctl (containerd/nerdctl#1334) . This idea of this PR is to ignore the InheritedFlags when there is conflict withflagandshorthandSigned-off-by: fahed dorgaa fahed.dorgaa@gmail.com