Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-signify instead of vim-gitgutter? #488

Closed
mhinz opened this issue Nov 4, 2013 · 8 comments
Closed

vim-signify instead of vim-gitgutter? #488

mhinz opened this issue Nov 4, 2013 · 8 comments

Comments

@mhinz
Copy link
Contributor

mhinz commented Nov 4, 2013

Disclaimer: I'm the author of vim-signify.

I understand that vim-gitgutter is already integrated and probably proved to be working. I don't even want to convince anyone to use Sy instead of vim-gitgutter. I haven't tried it for a long time either.

Moving might be a good choice nevertheless, since a lot of people seem to report that it works a lot faster. That alone should be a good reason. It also works not only for git, but for other popular version control systems as well. It also has some features that vim-gitgutter doesn't have.

I just wanted to leave this note. If you don't think changing is an option, just close this issue. :-)

@ljani
Copy link
Contributor

ljani commented Nov 4, 2013

Sadly no comments from @spf13 here either: #456. Of course this issue provides a lot better reasoning than the other one.

@mhinz
Copy link
Contributor Author

mhinz commented Nov 4, 2013

Oh, I didn't even see that issue. Thanks for mentioning.

@spf13
Copy link
Owner

spf13 commented Nov 4, 2013

I'm happy to merge a solid pull request, especially if you are willing to help with support.

gitgutter has been fine for me, but supporting other VCSs would be great.

@mhinz
Copy link
Contributor Author

mhinz commented Nov 4, 2013

Okay, I'll look into it, but it might take some days.

@mhinz
Copy link
Contributor Author

mhinz commented Nov 5, 2013

Okay, this is my first try. Play around with it a bit since I'm not sure what exact settings you want.

NOTE: Sign colors are linked to the default highlight groups DiffAdd, DiffChange, DiffDelete. (:h signify-section-colors for more information.)

p.s. I'll write a proper section for the README in case this gets accepted

@louy2
Copy link
Contributor

louy2 commented Nov 22, 2013

Since I have met some gitgutter error in #499 I would like to try this.

@jcbwlkr
Copy link
Contributor

jcbwlkr commented Nov 22, 2013

I've been using vim-signify on some of my machines and have generally preferred it. The ability to show diffs in other VCSs has been nice and I have not yet experienced some of the weird tmp file errors I used to get like what @louy2 mentioned.

@mhinz
Copy link
Contributor Author

mhinz commented Jul 15, 2015

This was merged a long time ago -> closed.

@mhinz mhinz closed this as completed Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants