Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groupings in BindPFlags #1537

Open
1 task done
heaths opened this issue Apr 12, 2023 · 1 comment
Open
1 task done

Support groupings in BindPFlags #1537

heaths opened this issue Apr 12, 2023 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@heaths
Copy link

heaths commented Apr 12, 2023

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

When you define pflags like so:

rootCmd.PersistentFlags().StringVar(&opts.Color.Comment, "color-comment", defaultColorComment, fmt.Sprintf("Hex RGB color code for comments e.g., %q.", defaultColorComment))
rootCmd.PersistentFlags().StringVar(&opts.Color.Error, "color-error", defaultColorError, fmt.Sprintf("Hex RGB color code for errors e.g., %q.", defaultColorError))
v.BindPFlags(rootCmd.PersistentFlags())

The flag name e.g., "color-comment" is not automatically matched to a section like so:

color:
  comment: "#00ff00"

Proposed Solution

When calling BindPFlags, any long name that is separated by certain characters e.g., "-" or ".", would automatically consider any prefixes to be a section e.g.,

"foo-bar-baz" would look for:

foo:
  bar:
    baz: ""

To avoid backcompat issues, this could be an Option set either in NewWithOptions or via explicit function call.

Alternatives Considered

No response

Additional Information

There is a workaround after reading #375 (comment), but it requires binding individual flags.

@heaths heaths added the kind/enhancement New feature or request label Apr 12, 2023
@github-actions
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant