travis: ensure dependencies are encoded in go.mod #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbza
force-pushed
the
prevent_future_mod_issues
branch
from
7a91c80
to
7fbb39a
Compare
Currently a user can add new deps in *.go files that do not exist in the go.mod/go.sum. This commit adds a small check in CI to ensure that no new deps were added that aren't in the go.mod/go.sum. This commit includes a run of `go mod tidy`.
jeanbza
force-pushed
the
prevent_future_mod_issues
branch
from
7fbb39a
to
1a6bfab
Compare
|
A slightly better option would be turning on readonly mode for go modules. Compilation will fail if there are missing dependencies. For example: https://github.com/sagikazarmark/modern-go-application/blob/master/.travis.yml#L20 |
Merged
|
I added the readonly flag so the build should fail if dependencies are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a user can add new deps in *.go files that do not exist in the
go.mod/go.sum. This commit adds a small check in CI to ensure that no new
deps were added that aren't in the go.mod/go.sum.