Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DebugWith method for specifying where debug output should go (#896) #897

Closed
wants to merge 1 commit into from

Conversation

cixel
Copy link

@cixel cixel commented Apr 20, 2020

This addresses the issue I opened in #896. To avoid breaking changes, I added a DebugWith instead of changing the signature of Debug. It doesn't do any sort of nil check or error handling.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2020

CLA assistant check
All committers have signed the CLA.

@sagikazarmark sagikazarmark added this to the v1.13.0 milestone Sep 3, 2022
@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Sep 3, 2022
@sagikazarmark
Copy link
Collaborator

Fixed in #1414

@cixel cixel deleted the debug-writer branch September 22, 2022 14:40
@cixel cixel restored the debug-writer branch September 22, 2022 14:40
@cixel cixel deleted the debug-writer branch September 22, 2022 14:40
@cixel cixel restored the debug-writer branch September 22, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants