-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install path of the headers #75
Comments
I have no specific install path. I expect users decide it. |
Well, of course. But
and
This confuses the build systems that have to provide a path to a library headers. If the library was build by |
I see. I finally failed to use autotools well. Cmake is now enough poplular. Do you think I am allowed to remove autotools support? |
Yes, I think so. CMake works just fine and there is no need to replicate the build process with |
avogadrolibs expects it to be installed as spglib/spglib.h, so is may be better to use the autoconf location. |
@StefanBruens, could you tell more in detail? |
https://github.com/OpenChemistry/avogadrolibs/blob/master/cmake/FindSpglib.cmake Also the sources contain "#include <spglib/spglib.h> So preferably, DESTINATION should be "%{CMAKE_INSTALL_INCLUDEDIR}/spglib" |
How about
? |
Maybe this can be considered as part of the As for downstream users, it would be great if someone can contact the devs to switch to using simple |
@LecrisUT This issue seems to be resolved. Can I close this issue? |
Good with me. Spglib's api is a single-header library so it shouldn't have a dedicated folder |
autotools
install the headers into $PREFIX/include/spglib/* whilecmake
installs a single spglib.h header into $PREFIX/include/spglib.hWhat is the expected install path and what is a deprecated path?
The text was updated successfully, but these errors were encountered: