install path of the headers

[toxa81]

autotools install the headers into $PREFIX/include/spglib/* while cmake installs a single spglib.h header into $PREFIX/include/spglib.h

What is the expected install path and what is a deprecated path?

[atztogo]

I have no specific install path. I expect users decide it.

[toxa81]

Well, of course. But autotools will place the headers under the spglib subfolder inside the include directory but not the cmake. This means the the host code has to choose between

#include <spglib/spglib.h>

and

#include <spglib.h>

This confuses the build systems that have to provide a path to a library headers. If the library was build by autotools or by cmake the location of headers is different.

[atztogo]

I see. I finally failed to use autotools well. Cmake is now enough poplular. Do you think I am allowed to remove autotools support?

[toxa81]

Do you think I am allowed to remove autotools support?

Yes, I think so. CMake works just fine and there is no need to replicate the build process with autotools.

[StefanBruens]

avogadrolibs expects it to be installed as spglib/spglib.h, so is may be better to use the autoconf location.

[atztogo]

@StefanBruens, could you tell more in detail?

[StefanBruens]

https://github.com/OpenChemistry/avogadrolibs/blob/master/cmake/FindSpglib.cmake

Also the sources contain "#include <spglib/spglib.h>

So preferably, DESTINATION should be "%{CMAKE_INSTALL_INCLUDEDIR}/spglib"

[atztogo]

How about

install(TARGETS symspg LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})

?

[LecrisUT]

Maybe this can be considered as part of the 2.0 release. Overall the standard syntax is that the main interface header is in the top include. Others use foldered structure if they want to include only components of the library. This is unnecessary for this library.

As for downstream users, it would be great if someone can contact the devs to switch to using simple find_package or FetchContent now that these will be available in the next minor release

[lan496]

@LecrisUT This issue seems to be resolved. Can I close this issue?

[LecrisUT]

Good with me. Spglib's api is a single-header library so it shouldn't have a dedicated folder