Fix pre-commit

[LecrisUT]

Closes #213

Note that there are some pre-commit that have not been fixed.

(Currently depends on #214 because I didn't rebase that out)

[LecrisUT]

@atztogo Can you help or assign someone to help with some of the C errors like malloc etc.?

[codecov-commenter]

Codecov Report

Base: 64.00% // Head: 64.00% // No change to project coverage 👍

Coverage data is based on head (14c3b57) compared to base (fb55b8f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #215   +/-   ##
========================================
  Coverage    64.00%   64.00%           
========================================
  Files           18       18           
  Lines         1328     1328           
========================================
  Hits           850      850           
  Misses         478      478           

Impacted Files	Coverage Δ
setup.py	0.00% <0.00%> (ø)
spglib/spglib.py	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[atztogo]

to help with some of the C errors like malloc etc.?

This part, I don't understand. What do you want? Have you met malloc errors?

[LecrisUT]

This part, I don't understand. What do you want? Have you met malloc errors?

If we run pre-commit now, clang-tidy fails due to various errors, one of them was a malloc issue, though I can't find it right now

[lan496]

Thank you so much for the quick fix! I confirm many warnings occur by running clang-tidy for all files, but it will be better to be addressed them in another PR.

Note for me: cmake-pre-commit-hooks creates a build directory (currently _build-pre-commit specified in .pre-commit-config.yaml) and compile_commands.json.

@atztogo I also think this PR is ready to be merged.

[atztogo]

Merged. Thanks @LecrisUT and @lan496.

[LecrisUT]

Note for me: cmake-pre-commit-hooks creates a build directory (currently _build-pre-commit specified in .pre-commit-config.yaml) and compile_commands.json.

Yeah, it can also use the pre-configured build directories. I chose against it because it might not collect all source code, e.g. if it's build with WITH_FORTRAN=OFF.