Add fortran interface test #230
Conversation
Initial fortran test was written following boilerplate of test_dummmy.F90. - test_dummy.F90 was changed to test_spg_get_symmetry.f90. - c_interface_module.F90 was removed. Probably this will not be used. - test/fortran/utils.f90 contains utilities for fortran tests. - pre-commit modified file tails of CMakeLists.txt's.
Codecov ReportBase: 93.34% // Head: 93.34% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #230 +/- ##
========================================
Coverage 93.34% 93.34%
========================================
Files 15 15
Lines 902 902
========================================
Hits 842 842
Misses 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| if (val /= ref_val) then | ||
| print '()' | ||
| print '(i0, "/=", i0)', val, ref_val | ||
| error stop |
There was a problem hiding this comment.
Does error give you a traceback or equivalent? Would be difficult to debug without that. Hopefully cmake's boilerplate can save us
There was a problem hiding this comment.
I assume, if the test in C (and python) works, spglib in C is fine. Because the fortran interface is very simple wrapper, if the test in fortran went wrong, most likely the test code is wrong, but the fortran wrapper is probably not wrong. Therefore, this print information is used for debugging the test code.
To see the traceback, we may have to compile spgilb with debugging option. Can we set set(CMAKE_BUILD_TYPE Debug) when spglib_WITH_TESTS=on? Or, is it already so?
There was a problem hiding this comment.
I've tested this a bit and even with Debug flag we don't get a traceback. At the same time though, there are no clean Fortran methods of doing so close to what standard C++, catch2 or GoogleTest (closest I've found is fortuno), but that doesn't define macros to automatically throw messages either.
But for what it's worth, I say it's good enough since we only need it to detect issues and then we can use a debugger.
Can we set
set(CMAKE_BUILD_TYPE Debug)whenspglib_WITH_TESTS=on
We shouldn't because users would want to run tests as well.
|
Also maybe worth changing the names to |
Absolutely! |
Initial fortran test was written following boilerplate of
test_dummy.F90.test_dummy.F90was changed totest_spg_get_symmetry.f90.c_interface_module.F90was removed. Probably this will not be used.test/fortran/utils.f90contains utilities for fortran tests. This was written by @atztogo.CMakeLists.txt's.