Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor python optional dependencies #268

Merged
merged 1 commit into from Apr 4, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Apr 3, 2023

  • Renamed optional dependencies to be closer to scikit-build. Aliases are kept for compatibility
  • Expanded optional dependencies to separate convergence and benchmark testing. Added development set with pre-commit
  • Fixed pytest option to not depend on pytest-benchmark

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT mentioned this pull request Apr 3, 2023
@LecrisUT LecrisUT requested a review from lan496 April 3, 2023 07:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (06f1799) 85.69% compared to head (7b5f6ff) 85.69%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #268   +/-   ##
========================================
  Coverage    85.69%   85.69%           
========================================
  Files           23       23           
  Lines         6069     6069           
========================================
  Hits          5201     5201           
  Misses         868      868           
Flag Coverage Δ
c_api 73.70% <ø> (ø)
fortran_api 37.37% <ø> (ø)
python_api 82.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LecrisUT LecrisUT merged commit bb8c35f into spglib:develop Apr 4, 2023
7 checks passed
@LecrisUT LecrisUT deleted the python/opt-deps branch April 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants