Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use container with pre-installed toolchains #285

Merged
merged 1 commit into from Jun 8, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Jun 7, 2023

I have a container that I am using with pre-installed toolchains (based on nlohmann/json-ci). If you want, we can migrate/copy/fork this to spglib organization for better control of the container os and toolchain versions.

A few things to note:

  • Containers are fedora based, so they don't have multiple compiler support like in Ubuntu
  • Containers are bare-bone without debugging packages.Trying to avoid the issues that nlohmann has maintaining a monolith container
  • Intel compiler is not available for Fedora38, ubuntu 23.04, etc. (supposedly will be fixed in 2023.2 release)

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@atztogo
Copy link
Collaborator

atztogo commented Jun 7, 2023

I have no idea about this, and I think it is good if you think it is good.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2380a3) 74.21% compared to head (fc40de6) 74.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #285   +/-   ##
========================================
  Coverage    74.21%   74.21%           
========================================
  Files           22       22           
  Lines         5588     5588           
========================================
  Hits          4147     4147           
  Misses        1441     1441           
Flag Coverage Δ
c_api 74.21% <ø> (ø)
fortran_api 37.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LecrisUT LecrisUT requested a review from lan496 June 7, 2023 09:29
@LecrisUT LecrisUT mentioned this pull request Jun 7, 2023
@LecrisUT LecrisUT changed the title Use container with pre-installed toolchains ci: Use container with pre-installed toolchains Jun 8, 2023
@LecrisUT LecrisUT merged commit 5903b41 into spglib:develop Jun 8, 2023
11 checks passed
@LecrisUT LecrisUT deleted the ci/dev-env branch June 8, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants