Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set C standard to C11 #304

Merged
merged 2 commits into from Jun 20, 2023
Merged

Set C standard to C11 #304

merged 2 commits into from Jun 20, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Jun 19, 2023

TODO:

  • Documentation

@LecrisUT LecrisUT requested review from lan496 and atztogo June 19, 2023 12:13
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +9.58 🎉

Comparison is base (fdcaafc) 76.48% compared to head (42c359d) 86.07%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
+ Coverage    76.48%   86.07%   +9.58%     
===========================================
  Files           22       23       +1     
  Lines         5576     6069     +493     
===========================================
+ Hits          4265     5224     +959     
+ Misses        1311      845     -466     
Flag Coverage Δ
c_api 76.48% <ø> (ø)
fortran_api 37.46% <ø> (ø)
python_api 82.83% <ø> (?)
unit_tests 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atztogo
Copy link
Collaborator

atztogo commented Jun 20, 2023

@LecrisUT, are we waiting for windows test by #286?

@LecrisUT
Copy link
Collaborator Author

For this one? No it's self-contained and all ready. Just need documentation review.

@atztogo
Copy link
Collaborator

atztogo commented Jun 20, 2023

I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers.

@LecrisUT
Copy link
Collaborator Author

I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers.

Oh in that sense. Sure this one is already a dependency for most of the PRs, #286 included. And indeed for that one the tests are passing (except the flakiness bug that I'm slowly trying to address with #303, #297 and other test improvements)

@LecrisUT
Copy link
Collaborator Author

Ok, see #286. Windows tests are passing with the C11 even on pytest 🎉. I have confirmed that the correct compiler is used in https://github.com/spglib/spglib/actions/runs/5319593736

Copy link
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The newer standard will make our lives easier.

@lan496 lan496 assigned LecrisUT and unassigned lan496 Jun 20, 2023
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Copy link
Collaborator Author

Screenshot_20230620_135849
Hmm, it didn't allow to set an auto-merge, maybe it only has an effect on future PRs.

@LecrisUT LecrisUT merged commit b7abe8d into spglib:develop Jun 20, 2023
11 checks passed
@LecrisUT LecrisUT deleted the C-standard branch June 20, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants