New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set C standard to C11 #304
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #304 +/- ##
===========================================
+ Coverage 76.48% 86.07% +9.58%
===========================================
Files 22 23 +1
Lines 5576 6069 +493
===========================================
+ Hits 4265 5224 +959
+ Misses 1311 845 -466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For this one? No it's self-contained and all ready. Just need documentation review. |
I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers. |
Oh in that sense. Sure this one is already a dependency for most of the PRs, #286 included. And indeed for that one the tests are passing (except the flakiness bug that I'm slowly trying to address with #303, #297 and other test improvements) |
Ok, see #286. Windows tests are passing with the C11 even on pytest 🎉. I have confirmed that the correct compiler is used in https://github.com/spglib/spglib/actions/runs/5319593736 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The newer standard will make our lives easier.
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
TODO: