New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: build wheel workflow #321
Conversation
3a6c9e4
to
fcb2cce
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #321 +/- ##
========================================
Coverage 83.60% 83.60%
========================================
Files 23 23
Lines 7942 7942
========================================
Hits 6640 6640
Misses 1302 1302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
69d100a
to
c82cb70
Compare
@lan496 This one can be merged, but after merging, trigger a Here is a run on my fork for reference if you want to wait for it before merging. |
Artifacts do not seem to be uploaded https://github.com/spglib/spglib/actions/runs/6073266832?pr=321. |
There seems to be a bug with running Yes, it is a bug: python/cpython#107846. Seems we have to wait for: python/cpython#107845 |
c9b38e0
to
226a772
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Can check the run here, specifically check the artifacts have all wheels |
It seems actions/upload-artifacts was skipped 🤔 |
Oh, right, I forgot to include the flag to upload this one should have it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've checked the artifact is uploaded.
Either the emulation is needed in order to build for linux-arm or we can try CircleCI.
Experimenting with CircleCI for a while in https://github.com/LecrisUT/spglib/actions/workflows/ci.yamlWill come back to CircleCI and CirrusCI in a later PR.