Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Julia packaging issues #341

Merged
merged 3 commits into from Dec 4, 2023
Merged

fix: Julia packaging issues #341

merged 3 commits into from Dec 4, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Oct 2, 2023

Trying to fix JuliaPackaging/Yggdrasil#7310, and do a bit of cleanup.

  • Added missing include(GoogleTest). It is surprising that this issue was not picked up by any other CI/downstream
  • Moved compilation warnings to only CI. Downstream is getting bombarded with warnings that are slow to fix and it makes it hard to debug on their side.
  • _Thread_local is not detected in Julia's packaging CI compiler issue on their end

@singularitti I will try to make some quick fixes here, but can you create the patches and try them on the Julia side CI?

After this we'll need to cherry-pick this one and add them to release-2.1 hotfix branch

@LecrisUT LecrisUT self-assigned this Oct 2, 2023
@LecrisUT LecrisUT changed the title fix: GoogleTest fix: Julia packaging issues Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02dedb) 83.80% compared to head (de9247c) 83.80%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #341   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           24       24           
  Lines         8167     8167           
========================================
  Hits          6844     6844           
  Misses        1323     1323           
Flag Coverage Δ
c_api 77.18% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.47% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LecrisUT and others added 3 commits December 4, 2023 17:40
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@lan496 lan496 merged commit 82c2a22 into spglib:develop Dec 4, 2023
29 of 45 checks passed
@singularitti
Copy link
Contributor

Hi @LecrisUT, when you say the "packaging issue is fixed", do you mean the tests can be run? Because I still cannot run these tests when building Spglib artifacts on Julia CI systems.

@LecrisUT
Copy link
Collaborator Author

@singularitti Yes, the packaging of Gtest itself should be fixed here, so it should more reliably pick it up. The issue you've encountered in JuliaPackaging/Yggdrasil@189ff1b is that there were no pre-downloaded sources of gtest.

The main issue as downstream put it is to do the tests in an emulated environment. I have an idea (#363) that would be useful for conda as well, where it can run the packaged versions on the real machine. Not sure about Julia CI if it can have a similar feature.

@LecrisUT LecrisUT deleted the fix/gtest branch January 22, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants