New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Julia packaging issues #341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #341 +/- ##
========================================
Coverage 83.80% 83.80%
========================================
Files 24 24
Lines 8167 8167
========================================
Hits 6844 6844
Misses 1323 1323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Hi @LecrisUT, when you say the "packaging issue is fixed", do you mean the tests can be run? Because I still cannot run these tests when building Spglib artifacts on Julia CI systems. |
@singularitti Yes, the packaging of Gtest itself should be fixed here, so it should more reliably pick it up. The issue you've encountered in JuliaPackaging/Yggdrasil@189ff1b is that there were no pre-downloaded sources of gtest. The main issue as downstream put it is to do the tests in an emulated environment. I have an idea (#363) that would be useful for conda as well, where it can run the packaged versions on the real machine. Not sure about Julia CI if it can have a similar feature. |
Trying to fix JuliaPackaging/Yggdrasil#7310, and do a bit of cleanup.
include(GoogleTest)
. It is surprising that this issue was not picked up by any other CI/downstreamcompiler issue on their end_Thread_local
is not detected in Julia's packaging CI@singularitti I will try to make some quick fixes here, but can you create the patches and try them on the Julia side CI?
After this we'll need to cherry-pick this one and add them to
release-2.1
hotfix branch