New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for noncollinear case and spg_get_symmetry_with_site_tensors of fortran interface #342
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #342 +/- ##
===========================================
+ Coverage 83.53% 83.56% +0.02%
===========================================
Files 24 24
Lines 8157 8157
===========================================
+ Hits 6814 6816 +2
+ Misses 1343 1341 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
How about adding the explanation of the max_size also in the documents? |
I agree, #345. Will be done in a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final comment, otherwise LGTM. Other test-suite issues should be addressed in #303.
Co-authored-by: Cristian Le <github@lecris.me>
Some more tests of Fortran interface: