Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for noncollinear case and spg_get_symmetry_with_site_tensors of fortran interface #342

Merged
merged 5 commits into from Oct 11, 2023

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Oct 3, 2023

Some more tests of Fortran interface:

  • Add tests for non-collinear case.
  • Add tests for spg_get_symmetry_with_site_tensors.

@atztogo atztogo changed the title Tests for noncollinear case and spg_get_symmetry_with_site_tensors Tests for noncollinear case and spg_get_symmetry_with_site_tensors of fortran interface Oct 3, 2023
@atztogo atztogo requested a review from LecrisUT October 3, 2023 07:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (37ec2a0) 83.53% compared to head (aa73972) 83.56%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
+ Coverage    83.53%   83.56%   +0.02%     
===========================================
  Files           24       24              
  Lines         8157     8157              
===========================================
+ Hits          6814     6816       +2     
+ Misses        1343     1341       -2     
Flag Coverage Δ
c_api 76.43% <ø> (+0.33%) ⬆️
fortran_api 56.31% <ø> (+1.34%) ⬆️
python_api 80.42% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo requested a review from LecrisUT October 7, 2023 12:58
@lan496
Copy link
Member

lan496 commented Oct 8, 2023

How about adding the explanation of the max_size also in the documents?

@atztogo
Copy link
Collaborator Author

atztogo commented Oct 8, 2023

How about adding the explanation of the max_size also in the documents?

I agree, #345. Will be done in a different PR.

Copy link
Collaborator

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final comment, otherwise LGTM. Other test-suite issues should be addressed in #303.

test/functional/c/test_magnetic_symmetry.cpp Outdated Show resolved Hide resolved
atztogo and others added 2 commits October 11, 2023 14:21
@atztogo atztogo merged commit a96d72a into spglib:develop Oct 11, 2023
43 of 49 checks passed
@atztogo atztogo deleted the test-noncollinear branch October 11, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants