Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fortran pkg-config file #357

Merged
merged 1 commit into from Dec 2, 2023
Merged

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Nov 9, 2023

Found this when working on an old debian container. Apparently depends is not the correct syntax it should be Requires. Surprised these were not picked up by the tmt tests

@LecrisUT
Copy link
Collaborator Author

I will write proper tests for this when I address #363

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02dedb) 83.80% compared to head (2a1798a) 83.80%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #357   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           24       24           
  Lines         8167     8167           
========================================
  Hits          6844     6844           
  Misses        1323     1323           
Flag Coverage Δ
c_api 77.18% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.47% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 merged commit 9c1099c into spglib:develop Dec 2, 2023
35 of 45 checks passed
@LecrisUT LecrisUT deleted the fix/fortran-pkgconf branch December 8, 2023 10:38
@LecrisUT LecrisUT added this to the 2.2 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants