Replace linter and formatter with ruff and mypy

[lan496]

Closes #364

[LecrisUT]

Also, just make sure when you apply pre-commit it's a separate commit, and we don't squash commit for this PR

[LecrisUT]

Why the ignore? Also should scope ignores

[lan496]

Without ignoring, mypy says

error: Module "spglib" has no attribute "_spglib"  [attr-defined]

[LecrisUT]

Yeah, but that's a genuine issue:

• We should be using relative paths there
• We should be providing a _spglib.pyi to type-hint the C interface, even if only internally

[lan496]

The relative path did not persuade mypy

    from .spglib import _spglib as spg
# -> Module "spglib.spglib" has no attribute "_spglib"  [attr-defined]

[LecrisUT]

Also worth referencing the scienitific-python configuration: https://github.com/scientific-python/cookie/blob/main/pyproject.toml

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba444f4) 83.86% compared to head (a28e63f) 83.86%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #392   +/-   ##
========================================
  Coverage    83.86%   83.86%           
========================================
  Files           24       24           
  Lines         8180     8180           
========================================
  Hits          6860     6860           
  Misses        1320     1320           

Flag	Coverage Δ
c_api	77.59% <ø> (ø)
fortran_api	56.15% <ø> (ø)
python_api	80.38% <ø> (ø)
unit_tests	1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LecrisUT]

Please split the "add mypy/ruff configuration" and "apply mypy/ruff” as separate commits in 31b2842. You can run git commit --no-verify to skip the pre-commit

[LecrisUT]

👍 for the current setup as an initial implementation. Mind if I rebase your commits a bit before merging?

[LecrisUT]

The size of the python bindings is very small, so might as well run mypy on all sources defined in pyproject.toml, i.e. running

$ mypy --ignore-missing-imports --scripts-are-modules

[lan496]

@LecrisUT No problem. I'll leave the rest to you.

[LecrisUT]

Sorry, had to change the committer because I've split the commits. Btw, can you add docs/readthedocs.org, and testing-farm:fedora-39 (and later fedora-38 as well) to the required workflows to pass? Otherwise if we use auto-merge now it would keep those checks dangling.

Also make sure to merge this with a merge commit or rebase to keep the history

[lan496]

Thanks to tidy commits. I've updated the branch protection rule. Is it OK?

[LecrisUT]

Yep, that looks good. I'll bother you again later when I enable Fedora38