Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows installation path #426

Merged
merged 1 commit into from Feb 7, 2024

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Feb 6, 2024

Closes #410

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Feb 6, 2024

I am writing the changelog for all the others, after final review, I will merge and resolve the conflicts one at a time

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13f714d) 83.71% compared to head (ae16065) 83.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #426   +/-   ##
========================================
  Coverage    83.71%   83.71%           
========================================
  Files           24       24           
  Lines         8205     8205           
========================================
  Hits          6869     6869           
  Misses        1336     1336           
Flag Coverage Δ
c_api 77.50% <ø> (ø)
fortran_api 56.33% <ø> (ø)
python_api 79.94% <ø> (ø)
unit_tests 1.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT mentioned this pull request Feb 6, 2024
Copy link
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT enabled auto-merge (squash) February 7, 2024 13:30
@LecrisUT LecrisUT merged commit a648e41 into spglib:develop Feb 7, 2024
36 of 40 checks passed
@LecrisUT LecrisUT deleted the fix/windows-install branch February 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows installation path is incorrect
2 participants