Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mixins): Remove unnecessary dependency (mixins) #52

Closed
wants to merge 1 commit into from
Closed

refactor(mixins): Remove unnecessary dependency (mixins) #52

wants to merge 1 commit into from

Conversation

adnasa
Copy link
Contributor

@adnasa adnasa commented Feb 10, 2017

block by commercetools/sphere-node-sdk#212
This removes underscore-mixins as a dependency, since it is rarely used.

This has been discussed with @Siilwyn

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.7%) to 40.25% when pulling e8bc015 on adnasa:remove-underscore-mixins into e419423 on sphereio:master.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 14, 2017

cc @hisabimbola

@hisabimbola
Copy link
Contributor

@adnasa

I guess you have push rights to this repo.

Can you create a branch and create a PR so that the builds will pass

@adnasa
Copy link
Contributor Author

adnasa commented Feb 14, 2017

@hisabimbola oh yeah, I can do that 😋

@adnasa adnasa closed this Feb 14, 2017
@adnasa adnasa deleted the remove-underscore-mixins branch February 14, 2017 17:02
@adnasa adnasa mentioned this pull request Feb 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siilwyn Siilwyn Awaiting requested review from Siilwyn

@hisabimbola hisabimbola Awaiting requested review from hisabimbola

Assignees

@Siilwyn Siilwyn

@hisabimbola hisabimbola

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adnasa @coveralls @hisabimbola @Siilwyn @PhilippSpo