-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M05 #27
Merged
Merged
M05 #27
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
682ffe0
added atomic upgrade contract
sfeyal 6e561d1
Merge branch 'L06' into L12
sfeyal 674eba7
Merge branch 'collecting-storage-internal-functions' into L12
sfeyal 120212d
atomic-engine-update-contract
sfeyal d8f3670
Merge remote-tracking branch 'origin/L11' into L12
sfeyal 834b7ad
handle factory
sfeyal fe314b5
factory solution
sfeyal 515f589
fixed typo added test
sfeyal c4f039f
gas report
sfeyal 2fee41d
fixed typos
sfeyal 5ee0b46
naming and doc string
sfeyal b96ebb0
operator initial value address(0)
sfeyal 4015f68
fixed event typo
sfeyal 5a05c3e
Achanged DD_ALLOWED_SENDER_ONCHAIN_INDEX value
sfeyal 22fd462
added an internal function to protected to add an allowed sender
sfeyal 39f2150
readme fix
sfeyal dc7f46a
another fix
sfeyal 1f8f68b
small cr fix
sfeyal 53335c0
deleted checks in init function
sfeyal c750127
fixed a bug when the engine is disabled when adding a new sender from…
sfeyal b4cd9e2
SphereXEngine.sol typos
ArielTM 852aa44
addAllowedSenderOnChain returnsIfNotActivated
sfeyal 57bc44e
added grantSenderAdderRole function
sfeyal 74112e8
removed super and fixed test
sfeyal e48ae7a
audit fixes
sfeyal 68ca9c2
rename init function
sfeyal 8680010
deleted L12 changes
sfeyal f0ae51b
Merge branch 'collecting-storage-internal-functions' into M05
sfeyal 052bb05
addAllowedSenderOnChain document flow
sfeyal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is super necessary? I think it's just when you have the same function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, and fixed test