translator: support v1 limited-page-width on server/dc #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding support for `confluence_full_width` with a v1 editor, the styling used only worked gracefully on Confluence Cloud. For Confluence Server/DC versions, the applied layout does not enforce any maximum width on the contained content. To improve this feature on Confluence Server/DC, we will use an alternative formatting for page content. Instead, we will opt to using a single div with a maximum width style applied. The maximum width chosen is based on the observed default max-width for macros when using the WYSIWYG editor. Signed-off-by: James Knight <james.d.knight@live.com>
With the Confluence v1 "full width" support, there is now different outputs based on if the target is a Cloud instance or a Server/DC instance. Updating unit testing to check/verify both of these scenarios. Signed-off-by: James Knight <james.d.knight@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for
confluence_full_widthwith a v1 editor, the styling used only worked gracefully on Confluence Cloud. For Confluence Server/DC versions, the applied layout does not enforce any maximum width on the contained content.To improve this feature on Confluence Server/DC, we will use an alternative formatting for page content. Instead, we will opt to using a single div with a maximum width style applied. The maximum width chosen is based on the observed default max-width for macros when using the WYSIWYG editor.