allow empty legacy pages set for new root content #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining legacy pages when purging, the base identifier used is either the parent container or a configured root page. When configured to purge from root and the root page does not yet exist, this can give a misrepresentation of what legacy pages are detected when a parent page is also configured. This commit changes this by force using the detected root page as the cleanup root. And if the cleanup root does not exist, a `None` root will result in an empty legacy pages set (which is expected). Signed-off-by: James Knight <james.d.knight@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining legacy pages when purging, the base identifier used is either the parent container or a configured root page. When configured to purge from root and the root page does not yet exist, this can give a misrepresentation of what legacy pages are detected when a parent page is also configured.
This commit changes this by force using the detected root page as the cleanup root. And if the cleanup root does not exist, a
Noneroot will result in an empty legacy pages set (which is expected).