Maintenance (2024-02-26) #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdknight
commented
Feb 27, 2024
jdknight
commented
- AUTHORS: updating authors
- enforce minimum sphinx v6.1 support
- correct comment spelling
- builder: drop legacy builder constructor
- drop legacy progress-msg/status-iterator calls
Adding/correcting a series of authors for introduced in various changes made to this extension. Signed-off-by: James Knight <james.d.knight@live.com>
While the documentation of this extension indicates explicit support to v6.1+, the Python project nor Sphinx version check never enforced this requirement. This is partially due to some partial support for some older versions (maybe back to Sphinx v5.x). With a window open to perform some maintenance, adjusting the configuration values to enforce the minimum versions (Requests is also bumped to match to the respective minimum version enforce by Sphinx). This will also allow the repository to drop a series of compatibility-related implementation in following commits. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Since we enforce a minimum Sphinx v6.1, there is no longer a need to maintain a compatibility call to a legacy super method; dropping. Signed-off-by: James Knight <james.d.knight@live.com>
Since we enforce a minimum Sphinx v6.1, there is no longer a need to maintain a compatibility calls to `process_message` and `status_iterator`; dropping. Signed-off-by: James Knight <james.d.knight@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.