Routingtable as label #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douardda
force-pushed
the
routingtable-as-label
branch
from
6a472aa
to
a76fced
Compare
dahlia
reviewed
Nov 28, 2018
swhmirror
pushed a commit
to SoftwareHeritage/swh-docs
that referenced
this pull request
Nov 29, 2018
this aims at eliminating a warning generated by sphinx-build on swh-web's index, due to the presence of an explicit link to the http-routingtable.html file (which does not exists at that time, thus generated a warning). This should be killed once sphinx-contrib/httpdomain#19 is accepted and released.
|
@dahlia yup, but which version are we targeting? 1.7.1 or 1.8? |
|
@douardda As its target branch is master, the target version should be 1.8.0. |
douardda
force-pushed
the
routingtable-as-label
branch
from
a76fced
to
bdacb4a
Compare
|
@dahlia ok I think it should be good now. |
dahlia
reviewed
Nov 29, 2018
doc/conf.py
Outdated
| # The full version, including alpha/beta/rc tags. | ||
| release = '1.7.0' | ||
| release = '1.9.0' |
There was a problem hiding this comment.
It seems typo. It should be 1.8.0.
using the 'routingtable' label, ie. writing :ref:`routingtable` in rst docs.
…label also add a new changelog entry.
douardda
force-pushed
the
routingtable-as-label
branch
from
bdacb4a
to
141723c
Compare
|
Indeed, sorry my keyboard tend to double strokes (used ^A in vim). |
dahlia
approved these changes
Nov 29, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the generated routing table "referencable" using the 'routingtable' label.