Fixed issue where explicit targets for thumbnail directives where ign…

…ored, making thumbnails unreferrable
sphinx-contrib · Aug 1, 2021 · 1871129 · 1871129
1 parent 85da3e3
commit 1871129
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Issue where explicit targets for thumbnails where ignored. 
+  `.. _my target:` before a thumbnail directive would not make the thumbnail 
+  referrable by `:ref:Title <my target>`.
+
+
 ## [0.9.3] - 2021-04-27
 
 ### Fixed

diff --git a/sphinxcontrib_images_lightbox2/lightbox2.py b/sphinxcontrib_images_lightbox2/lightbox2.py
@@ -33,15 +33,18 @@ def visit_image_node_html(self, writer, node):
                 writer.body.append(u'''<a ''')
         else:
             writer.body.append(u'''<a class="{cls}"'''.format(cls=' '.join(node['classes']),))
+
         writer.body.append(
             u'''
                data-lightbox="{group}"
                href="{href}"
                title="{title}"
                data-title="{title}"
+               id="{id}"
                >'''.format( group='group-%s' % node['group'] if node['group'] else node['uri'],
                             href=node['uri'],
                             title=node['title'] + node['content'],
+                            id = node['ids'][0] # Only one id attribute allowed
                             ))
         writer.body.append(
             '''<img src="{src}"