Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close ssh-add stdin for pull requests. #5

Closed
Robpol86 opened this issue Aug 3, 2016 · 2 comments
Closed

Close ssh-add stdin for pull requests. #5

Robpol86 opened this issue Aug 3, 2016 · 2 comments

Comments

@Robpol86
Copy link
Collaborator

Robpol86 commented Aug 3, 2016

Change line in docs to eval $(ssh-agent -s); ssh-add docs/key <&-

First discovered in: Robpol86/terminaltables#32

This probably happens because during pull requests there is no encrypted env variables so docs/key is empty or invalid. Thus ssh-add prompts for a password.

@Robpol86
Copy link
Collaborator Author

Robpol86 commented Aug 4, 2016

Closing stdin didn't actually do anything. Running ssh-add conditionally instead.

@Robpol86
Copy link
Collaborator Author

Robpol86 commented Aug 4, 2016

Fixed in 09e6b08

@Robpol86 Robpol86 closed this as completed Aug 4, 2016
Robpol86 added a commit to Robpol86/sphinx-imgur that referenced this issue Aug 4, 2016
Robpol86 added a commit to Robpol86/sphinx-disqus that referenced this issue Aug 4, 2016
Robpol86 added a commit to Robpol86/terminaltables that referenced this issue Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant