Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add --keep-going #109

Merged
merged 1 commit into from
Dec 24, 2022
Merged

[ENH] Add --keep-going #109

merged 1 commit into from
Dec 24, 2022

Conversation

cblegare
Copy link
Contributor

Fixes #108

Add --keep-going

Add --keep-going
@welcome
Copy link

welcome bot commented May 12, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@cblegare cblegare changed the title Add --keep-going [ENH] Add --keep-going May 12, 2021
Copy link

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for this improvement

@choldgraf choldgraf merged commit 6af4e40 into sphinx-doc:main Dec 24, 2022
@welcome
Copy link

welcome bot commented Dec 24, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@julian-poidevin
Copy link
Contributor

@cblegare Thank for this patch, I'm trying to use the --keep-going argument but this is failing (I manually installed commit 6af4e40 version) . Am I using it wrongly or is this a bug (in which case I'll open an issue).

Here's my command :

sphinx-autobuild --open-browser "source" "build" -D version=1.3 -D release=1.3.0 -W --keep-going

Here's the error :

Traceback (most recent call last):
  File "/workspaces/comboard-linux-image/docs/.venv/bin/sphinx-autobuild", line 8, in <module>
    sys.exit(main())
  File "/workspaces/comboard-linux-image/docs/.venv/src/sphinx-autobuild/src/sphinx_autobuild/cli.py", line 174, in main
    build_args, pre_build_commands = _get_build_args(args)
  File "/workspaces/comboard-linux-image/docs/.venv/src/sphinx-autobuild/src/sphinx_autobuild/cli.py", line 21, in _get_build_args
    val = getattr(args, arg)
AttributeError: 'Namespace' object has no attribute '-keep-going'
make: *** [Makefile:58: livehtml] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing --keep-going sphinx-build flags
3 participants