You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, sphinx generates a <div class="toctree-wrapper compound"> </div> even when toctree is :hidden:.
I think it'd be more consistent if nothing was added to the DOM when toctree is hidden.
My guess is that it boils down to changing this part of the code
and maybe only run ret.append(wrappernode) when subnode['hidden'] is not False?
Let me know what you think!
How to Reproduce
$ git clone https://github.com/.../some_project
$ cd some_project
$ pip install -r requirements.txt
$ cd docs
$ make html SPHINXOPTS="-D language=de"
$ # open _build/html/index and see bla bla
Describe the bug
Currently, sphinx generates a
<div class="toctree-wrapper compound"> </div>
even when toctree is:hidden:
.I think it'd be more consistent if nothing was added to the DOM when toctree is hidden.
My guess is that it boils down to changing this part of the code
sphinx/sphinx/directives/other.py
Lines 79 to 85 in f38bd8e
and maybe only run
ret.append(wrappernode)
whensubnode['hidden']
is notFalse
?Let me know what you think!
How to Reproduce
Expected behavior
No response
Your project
https://github.com/nilearn/nilearn
Screenshots
No response
OS
Ubuntu
Python version
3.9
Sphinx version
4.3.2
Sphinx extensions
No response
Extra tools
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: