Highlight all search terms on the search results page

[mitya57]

Subject: Highlight all search terms on search results page

Feature or Bugfix

• Bugfix

Purpose

SphinxHighlight.highlightSearchWords() is called on DOMContentLoaded event, and it will not highlight page fragments loaded asynchronously after that event. Also, when doing two searches in a row, that function uses search term from the previous search query because it was saved in localstorage.

So we should highlight all such fragments manually.

(At first I tried to rehighlight the whole page by calling SphinxHighlight.highlightSearchWords() after each fragment is loaded. It did not work because the first invocation deleted sphinx_highlight_terms from localstorage, so all subsequent invocations did not work.)

Relates

• Fixes highlightSearchWords() is not called after fragments are loaded via AJAX #10864.

[mitya57]

I have pushed a new version of this PR with two improvements:

• Now it highlights all occurrences of search term in a fragment, not just the first one.
• highlightSearchWords() is no longer called on the search page at all. First, it's no longer needed after my changes. Second, it was wrong because it uses search terms from the previous search query, not from the current one.

Now our WebKit-based tests in Debian finally pass in a reproducible way (previously they have been failing from time to time because of race condition between highlightSearchWords() and my new code).

@AA-Turner Sorry for direct ping, but I don't want this PR to be buried under a bunch of more recent ones, so whenever you have time, please take a look.

[AA-Turner]

Thanks @mitya57!

A