Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkcheck builder: don't retry with HTTP GET after SSLError on HTTP HEAD #11431

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented May 21, 2023

Feature or Bugfix

  • Bugfix

Purpose

  • If an SSLError occurs following an HTTP HEAD operation, it seems unlikely that a subsequent HTTP GET will succeed, so don't attempt one.

Detail

Relates

Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayaddison
Copy link
Contributor Author

Thank you, @francoisfreitag!

@AA-Turner AA-Turner merged commit 13720de into sphinx-doc:master Jul 20, 2023
27 checks passed
@jayaddison
Copy link
Contributor Author

Thanks, @AA-Turner!

@jayaddison jayaddison deleted the issue-9592/fixup-consider-sslerror-non-retryable branch July 22, 2023 08:45
jayaddison added a commit to jayaddison/sphinx that referenced this pull request Aug 1, 2023
AA-Turner pushed a commit that referenced this pull request Aug 2, 2023
AA-Turner pushed a commit that referenced this pull request Aug 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants