-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx 7.1 breaks Furo's usage of css_tag(css) on Windows #11518
Comments
This is a problem with Furo, it seems -- As such I don't think I consider this a breaking change in Sphinx. Sorry not to be more helpful. A |
Ahh, it must be https://github.com/pradyunsg/furo/blob/f8db95bed5d1c57b4ea6bf536c65560fa9ae33a9/src/furo/__init__.py#L149-L153 then. Thanks! Will open an issue there. |
FWIW, it isn't limited to Furo -- at least one more theme is broken by this change. :) |
Can confirm that I can't build the matplotlib docs anymore either, which means it's also breaking pydata-sphinx, and downgrading to 7.0 removes this error. OSError: [Errno 22] Invalid argument: 'C:\\Users\\story\\Projects\\matplotlib\\doc\\build\\html\\_static/pygments.css?v3.7.1-2022-g9676e766d4-dirty'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\cmd\build.py", line 290, in build_main
app.build(args.force_all, args.filenames)
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\application.py", line 351, in build
self.builder.build_update()
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\builders\__init__.py", line 290, in build_update
self.build(to_build,
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\builders\__init__.py", line 360, in build
self.write(docnames, list(updated_docnames), method)
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\builders\__init__.py", line 567, in write
self._write_serial(sorted(docnames))
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\builders\__init__.py", line 577, in _write_serial
self.write_doc(docname, doctree)
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\builders\html\__init__.py", line 675, in write_doc
self.handle_page(docname, ctx, event_arg=doctree)
File "C:\Users\story\miniconda3\envs\mpl-dev\Lib\site-packages\sphinx\builders\html\__init__.py", line 1105, in handle_page
raise ThemeError(__("An error happened in rendering the page %s.\nReason: %r") %
sphinx.errors.ThemeError: An error happened in rendering the page api/_api_api.
Reason: OSError(22, 'Invalid argument') |
Consider reporting that to pydata-sphinx-theme? |
I managed to reproduce; please see matplotlib/matplotlib#26493 for a proposed fix. A |
@AA-Turner Do you think it's worth improving the error message in this case? |
Done in 44a7820, thank you for the suggestion. A |
Awesome, thanks for the quick change! :) |
Describe the bug
The 7.1.0 release is breaking the Furo theme;
css_tag(css)
is causing a file to be attempted to be opened with?digest=e6660623a769aa55fea372102b9bf3151b292993
added to it, which of course breaks.If it's @pradyunsg's Furo's fault, I can open an issue there instead, but this looks like it's an issue with the checksum additions mentioned for 7.1.0? Especially since it only happens on Windows.
Seen in scikit-build/scikit-build-core#440 and scikit-build/scikit-build-core#441.
How to Reproduce
It's hard for me to test, since it's Windows only. Building Scikit-build-core's docs (via nox) on Windows would repeat it. I think any usage of Furo would break it, it doesn't seem to be specific, as it's loading a css file. Maybe other themes that have this construct.
Environment Information
Sphinx extensions
I think it can be done with just a theme.
Additional context
No response
The text was updated successfully, but these errors were encountered: