New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always say why something is out of date #11572
Conversation
Looks like this has actually been fixed on |
https://github.com/sphinx-doc/sphinx/actions/runs/5821558864/job/15784236771?pr=11572#step:9:2434
|
Wow. Ok, so maybe |
Ahhh okay this is indeed probably the problem -- I'll simplify the code and push soon! |
Okay finally green! |
Please may you add an entry to CHANGES? A |
Done @AA-Turner ! |
Windows failure looks probably unrelated... is it a flakey test? |
Thank you @larsoner! A |
Adds logging in two branches that was missing from the
logger.debug
. Gives output like:Perhaps it's a bit verbose but it at least indicates that this file is marked outdated because a dependency of it was created after the file that uses it.
BUT this brings up an issue -- the dependency itself was not changed the two calls to
make html
. The conditionalif depmtime > mtime:
around line 501 checks if themtime
of the file during previous build is older than that of the dependency in this build, when it seems like it should check if themtime
of the dependency during previous build is older than that of the dependency in this build. In other words, if I createindex.rst
, then createwhatever.inc
, and.. include: whatever.inc
,index.rst
will always show up as out of date just because of the order in which I createdindex
andwhatever.inc
.Should I try to fix that here as well? It seems like a potentially tough thing to fix because it would mean adding all dependency files to
self.all_docs
(whereself
is theBuildEnvironment
) -- or maybe better adding aself.all_deps
that is a str->float mtime mapping for all dependencies.