Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print template path chain in TemplateNotFound exception #11886

Merged
merged 3 commits into from Jan 16, 2024
Merged

Print template path chain in TemplateNotFound exception #11886

merged 3 commits into from Jan 16, 2024

Conversation

cmarqu
Copy link
Contributor

@cmarqu cmarqu commented Jan 16, 2024

Subject: Print template path chain in TemplateNotFound exception

Feature or Bugfix

  • Feature

Purpose

  • Make it easier for theme authors etc. to debug jinja2's TemplateNotFound exceptions by printing the considered paths

Detail

  • n/a

Relates

  • n/a

AA-Turner
AA-Turner approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add a CHANGES entry and resolve the ruff failures?

A

@cmarqu cmarqu force-pushed the feat/print-pathchain-in-exc branch from 65c2e63 to 061f6be Compare January 16, 2024 19:26
@cmarqu
Copy link
Contributor Author

cmarqu commented Jan 16, 2024

Done.

AA-Turner
AA-Turner reviewed Jan 16, 2024
View reviewed changes
sphinx/jinja2glue.py Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
@AA-Turner AA-Turner merged commit 9c59a6e into sphinx-doc:master Jan 16, 2024
22 checks passed
@AA-Turner
Copy link
Member

Thanks Colin!

A

@cmarqu cmarqu deleted the feat/print-pathchain-in-exc branch January 16, 2024 20:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmarqu @AA-Turner