Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Search: Partial matches can overwrite main matches in certain rare cases #11957

Closed
wlach opened this issue Feb 6, 2024 · 2 comments · Fixed by #11958
Closed

HTML Search: Partial matches can overwrite main matches in certain rare cases #11957

wlach opened this issue Feb 6, 2024 · 2 comments · Fixed by #11958

Comments

@wlach
Copy link
Contributor

wlach commented Feb 6, 2024

Describe the bug

In the case of the first document in a Sphinx index, partial matches can overwrite the main one. This causes the rank to be artificially lowered.

How to Reproduce

This is difficult to reproduce manually, I will reproduce it with a unit test when I file a PR.

Environment Information

Sphinx main as of 2024-02-06: e976059

Sphinx extensions

No response

Additional context

No response

@jayaddison
Copy link
Contributor

I'm relatively confident that this is a problem with the structure of our test fixture that does not affect the search indices for projects that have been built into HTML deployments; see #12028 for details, and feel free to re-open if I'm (provably, preferably!) incorrect.

@jayaddison jayaddison closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
@jayaddison
Copy link
Contributor

My mistake closing this; terms in the JS search index that only exist in a single document are represented as standalone integers, not as the elements of list/array types.

@jayaddison jayaddison reopened this Mar 2, 2024
@jayaddison jayaddison added javascript Pull requests that update Javascript code type:performance and removed type:performance javascript Pull requests that update Javascript code labels Mar 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants