Update note_labels_from() to extract figure captions.

[shimizukawa]

Reported by isopogon, Sep 17, 2008

The attached patch changes note_labels_from() to extract figure captions as
labels, so :ref: to a figure gets the correct label.

sphinx-figure-caption-patch

1022 bytes Download

Comment 1 by georg.brandl, Sep 17, 2008

Does every figure node contain a caption? If not, sectname may be undefined after the
elif block.

Labels: Type-Enhancement Milestone-0.5 Component-Markup

Comment 2 by isopogon, Sep 17, 2008

Ah. Whoops. I'll fix that and upload another patch.

Comment 3 by isopogon, Sep 17, 2008

Okay, this should work better.

sphinx-figure-caption-patch2

1.0 KB Download

Comment 4 by georg.brandl, Sep 24, 2008

Thanks! Committed in r66591.

---

• Bitbucket: https://bitbucket.org/birkenfeld/sphinx/issue/16
• Originally reported by: Georg Brandl
• Originally created at: 2008-11-02T22:22:52.804

[shimizukawa]

From Georg Brandl on 2010-08-25 12:19:05+00:00

Removing milestone: 0.5 (automated comment)