Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2027: make epub got errors if html_title is None #2208

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jan 1, 2016

Sphinx does not expect setting None value as html_title in
spite of documented.
This changed that to deny None value as html_title.

Sphinx does not expect setting None value as ``html_title`` in
spite of documented.
This changed that to deny None value as ``html_title``.
@tk0miya
Copy link
Member Author

tk0miya commented Jan 1, 2016

This is a fix for #2027 .

@shimizukawa
Copy link
Member

LGTM! Please merge it and update CHANGES.

@shimizukawa shimizukawa added this to the 1.4 milestone Jan 17, 2016
tk0miya added a commit that referenced this pull request Jan 17, 2016
…ring

Fix #2027: ``make epub`` got errors if ``html_title`` is None
@tk0miya tk0miya merged commit 8c8f3db into sphinx-doc:master Jan 17, 2016
tk0miya added a commit that referenced this pull request Jan 17, 2016
@tk0miya
Copy link
Member Author

tk0miya commented Jan 17, 2016

Thank you for reviewing. I merged it.

@tk0miya tk0miya deleted the 2027_html_title_only_accepts_string branch January 17, 2016 10:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants