Stop enforcing that favicon's must be .ico #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for at least .png and .gif is now essentially universal, and other formats (.jpg, .svg, etc.) are relatively widespread. This was only a warning, but it's common to run sphinx with warnings turned into errors, so it caused problems.
|
Thank you for updating! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for at least .png and .gif is now essentially universal, and
other formats (.jpg, .svg, etc.) are relatively widespread.
This was only a warning, but it's common to run sphinx with warnings
turned into errors, so it caused problems.
[Redo of #3715, now targeted at stable instead of master]