Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --keep-going with BuildDoc setup command #6180

Merged
merged 2 commits into from Mar 17, 2019
Merged

Support --keep-going with BuildDoc setup command #6180

merged 2 commits into from Mar 17, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 16, 2019

This allows for tox -e docs -- -n -W --keep-going.

@blueyed
Support --keep-going with BuildDoc setup command
98849b9 
This allows for `tox -e docs -- -n -W --keep-going`.
@codecov
Copy link

codecov bot commented Mar 16, 2019 •
edited

Codecov Report

Merging #6180 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6180      +/-   ##
==========================================
- Coverage   82.75%   82.75%   -0.01%     
==========================================
  Files         275      275              
  Lines       39404    39405       +1     
  Branches     5885     5885              
==========================================
  Hits        32609    32609              
- Misses       5466     5467       +1     
  Partials     1329     1329
Impacted Files Coverage Δ
sphinx/cmd/build.py 0% <ø> (ø) ⬆️
sphinx/setup_command.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783d077...b7fe3fd. Read the comment docs.

tk0miya
tk0miya approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

sphinx/locale/sphinx.pot Outdated Show resolved Hide resolved
@tk0miya tk0miya added the type:proposal a feature suggestion label Mar 17, 2019
@tk0miya tk0miya added this to the 2.1.0 milestone Mar 17, 2019
blueyed
blueyed commented Mar 17, 2019
View reviewed changes
sphinx/locale/sphinx.pot Outdated Show resolved Hide resolved
@blueyed
Copy link
Contributor Author

blueyed commented Mar 17, 2019

Ok. Please squash-merge then.

@tk0miya tk0miya merged commit 925bc18 into sphinx-doc:master Mar 17, 2019
@tk0miya
Copy link
Member

tk0miya commented Mar 17, 2019

Thank you for quick work! Merged!

tk0miya added a commit that referenced this pull request Mar 17, 2019
@tk0miya
Update CHANGES for PR #6180
fadab68
@blueyed blueyed deleted the setup-keep_going branch March 17, 2019 06:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tk0miya tk0miya tk0miya approved these changes

Assignees
No one assigned
Labels
type:proposal a feature suggestion
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blueyed @tk0miya